Ensure time interval comparisons are in UTC #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ridley <[email protected]>
Signed-off-by: Ben Ridley <[email protected]>
benridley
force-pushed
the
bugfix_mutetime_utc
branch
from
78fc1e0 to
c70481f
Compare
Signed-off-by: Ben Ridley <[email protected]>
Signed-off-by: Ben Ridley <[email protected]>
roidelapluie
approved these changes
Jul 22, 2021
|
thanks |
2 tasks
|
@roidelapluie Just wanted to make sure too that we mention this in the release notes for the next version. Some people might already have mute times setup that assume local time and this will break them :(. |
|
This was released in 2.23 |
|
Oh! I didn't realize we had a release already. No worries, at least this change makes the behavior consistent with the documentation so hopefully it won't surprise too many users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mute time mechanism uses the internal timer of alert aggregation groups to determine the current time, which is then used to determine whether a route should be muted. By default, this time fires in the local time of the server, not UTC as desired.
This PR ensures comparisons are only made in UTC.